chore: add feature flag report to package #32607
Conversation
Include a file `recommended-feature-flags.json` into the `aws-cdk-lib` package. The CLI will read this file when it creates a new project.
rix0rrr
requested a deployment
to
test-pipeline
GitHub Actions
Waiting
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
aws-cdk-automation
added
the
pr/needs-cli-test-run
rix0rrr
requested a deployment
to
test-pipeline
GitHub Actions
Waiting
rix0rrr
requested a deployment
to
test-pipeline
GitHub Actions
Waiting
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #32607 +/- ##
==========================================
+ Coverage 80.52% 80.54% +0.01%
==========================================
Files 106 106
Lines 6948 6954 +6
Branches 1287 1287
==========================================
+ Hits 5595 5601 +6
Misses 1175 1175
Partials 178 178
Flags with carried forward coverage won't be shown. Click here to find out more.
|
rix0rrr
temporarily deployed
to
test-pipeline
GitHub Actions
Inactive
|
➡️ PR build request submitted to A maintainer must now check the pipeline and add the |
rix0rrr
added
the
pr-linter/cli-integ-tested
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
aws-cdk-automation
removed
the
pr/needs-cli-test-run
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
rix0rrr
requested a deployment
to
test-pipeline
GitHub Actions
Waiting
rix0rrr
requested a deployment
to
test-pipeline
GitHub Actions
Waiting
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. |
Include a file
recommended-feature-flags.jsoninto theaws-cdk-libpackage.At build time, the CLI will copy the current
aws-cdk-libandconstructsversion, as well as the feature flag report, into its own package directory, and it will use those to initialize a new project.This decouples the init version number from the CLI version number, and it removes the need for the CLI to read
cx-apiat init time.Closes https://github.com/aws/aws-cdk-cli/issues/7
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license